MINOR: [C++] Remove TODO asking why null count set unknown#48823
Merged
lidavidm merged 1 commit intoapache:mainfrom Jan 15, 2026
Merged
MINOR: [C++] Remove TODO asking why null count set unknown#48823lidavidm merged 1 commit intoapache:mainfrom
lidavidm merged 1 commit intoapache:mainfrom
Conversation
HyukjinKwon
changed the title
HyukjinKwon
force-pushed
the
minor-remove-todo-q
branch
from
71d1b2c to
0cabd93
Compare
github-actions
bot
added
awaiting committer review
lidavidm
approved these changes
Jan 15, 2026
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit d65eb94. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Member
Author
|
Thank you guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Removed a TODO from
replace_with_maskimplementation that asking why the replacements null count wasn't sufficient for a slice operation. When slicing an array, the null count from the original full array doesn't apply to the slice.The null count must be marked as
kUnknownNullCountand computed lazily when needed.What changes are included in this PR?
Replaced the TODO with some comments clarifying:
ArrayData::Slice())kUnknownNullCountis necessary (original null count doesn't apply to slice)Are these changes tested?
No, I did not test.
Are there any user-facing changes?
No.